[VOTE] Release Apache NLPCraft (Incubating) 0.6.2

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache NLPCraft (Incubating) 0.6.2

Aaron Radzinski
Hello all,
This is a call for a vote to release Apache NLPCraft (incubating) version
0.6.2. Apache NLPCraft is a library for adding a natural language interface
to any application.

The Apache NLPCraft community has voted on and approved a proposal to
release Apache NLPCraft (Incubating) version 0.6.2. We would like to
request the Incubator PMC members review and vote on this incubator release.

Release information:
1. PPMC vote result thread:
https://mail-archives.apache.org/mod_mbox/nlpcraft-dev/202007.mbox/%3CCACwEJt8UFyDacVOa-MpwYj8s-c8vfFXbhmR%3DL1XBdtA4RKyJ7g%40mail.gmail.com%3E
2. Release location:
https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.6.2/
3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.6.2
4. JIRA issues fixed in release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323722&version=12347775
5. KEYS file:
https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS

The vote will be open for at least 72 hours or until a necessary number of
votes are reached.

Please vote accordingly:
+1 approve
+0 no opinion
-1 disapprove with the reason

Thank you,
--
Aaron Radzinski
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.6.2

Furkan KAMACI
Hi,

+1 from me (binding, carrying over my vote).

I checked:

- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked Checksums
- Code compiles and tests successfully run
- Apache rat checks are OK

PS: I still get these errors on Apache rat checks which may not be crucial:

[ERROR] VM #displayTree: error : too few arguments to macro. Wanted 2 got 0
[ERROR] VM #menuItem: error : too few arguments to macro. Wanted 1 got 0

Kind Regards,
Furkan KAMACI

On Wed, Jul 15, 2020 at 8:23 PM Aaron Radzinski <[hidden email]>
wrote:

> Hello all,
> This is a call for a vote to release Apache NLPCraft (incubating) version
> 0.6.2. Apache NLPCraft is a library for adding a natural language interface
> to any application.
>
> The Apache NLPCraft community has voted on and approved a proposal to
> release Apache NLPCraft (Incubating) version 0.6.2. We would like to
> request the Incubator PMC members review and vote on this incubator
> release.
>
> Release information:
> 1. PPMC vote result thread:
>
> https://mail-archives.apache.org/mod_mbox/nlpcraft-dev/202007.mbox/%3CCACwEJt8UFyDacVOa-MpwYj8s-c8vfFXbhmR%3DL1XBdtA4RKyJ7g%40mail.gmail.com%3E
> 2. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.6.2/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.6.2
> 4. JIRA issues fixed in release:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323722&version=12347775
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> +1 approve
> +0 no opinion
> -1 disapprove with the reason
>
> Thank you,
> --
> Aaron Radzinski
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.6.2

Konstantin Boudnik-2
In reply to this post by Aaron Radzinski
+1 [binding]

- DISCLAIMER exists
- LICENSE and NOTICE as expected
- No binary files
- Signatures and checksums are ok

--
With regards,
   Cos

On 2020-07-16 00:23, Aaron Radzinski wrote:

> Hello all,
> This is a call for a vote to release Apache NLPCraft (incubating) version
> 0.6.2. Apache NLPCraft is a library for adding a natural language interface
> to any application.
>
> The Apache NLPCraft community has voted on and approved a proposal to
> release Apache NLPCraft (Incubating) version 0.6.2. We would like to
> request the Incubator PMC members review and vote on this incubator release.
>
> Release information:
> 1. PPMC vote result thread:
> https://mail-archives.apache.org/mod_mbox/nlpcraft-dev/202007.mbox/%3CCACwEJt8UFyDacVOa-MpwYj8s-c8vfFXbhmR%3DL1XBdtA4RKyJ7g%40mail.gmail.com%3E
> 2. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.6.2/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.6.2
> 4. JIRA issues fixed in release:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323722&version=12347775
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> +1 approve
> +0 no opinion
> -1 disapprove with the reason
>
> Thank you,
> --
> Aaron Radzinski
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.6.2

Paul King
+1 carrying my vote over from the dev list

Checked hashes and signatures.
"maven clean verify" passes (fails for me on Windows JDK8 as per
NLPCRAFT-76, passes on Linux JDK11)
"maven apache-rat:rat" passes (but it is configured to ignore failures, you
can change numUnapprovedLicenses in the pom from 1000000 to 0 and it still
currently passes) UPDATE: fixed in master
incubating in name
DISCLAIMER exists
NOTICE seems okay
LICENSE seems okay
no unexpected binary files
licensing issues found by Justin last time seem sorted


On Fri, Jul 17, 2020 at 3:54 PM Konstantin Boudnik <[hidden email]> wrote:

> +1 [binding]
>
> - DISCLAIMER exists
> - LICENSE and NOTICE as expected
> - No binary files
> - Signatures and checksums are ok
>
> --
> With regards,
>    Cos
>
> On 2020-07-16 00:23, Aaron Radzinski wrote:
> > Hello all,
> > This is a call for a vote to release Apache NLPCraft (incubating) version
> > 0.6.2. Apache NLPCraft is a library for adding a natural language
> interface
> > to any application.
> >
> > The Apache NLPCraft community has voted on and approved a proposal to
> > release Apache NLPCraft (Incubating) version 0.6.2. We would like to
> > request the Incubator PMC members review and vote on this incubator
> release.
> >
> > Release information:
> > 1. PPMC vote result thread:
> >
> https://mail-archives.apache.org/mod_mbox/nlpcraft-dev/202007.mbox/%3CCACwEJt8UFyDacVOa-MpwYj8s-c8vfFXbhmR%3DL1XBdtA4RKyJ7g%40mail.gmail.com%3E
> > 2. Release location:
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.6.2/
> > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.6.2
> > 4. JIRA issues fixed in release:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323722&version=12347775
> > 5. KEYS file:
> > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >
> > The vote will be open for at least 72 hours or until a necessary number
> of
> > votes are reached.
> >
> > Please vote accordingly:
> > +1 approve
> > +0 no opinion
> > -1 disapprove with the reason
> >
> > Thank you,
> > --
> > Aaron Radzinski
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.6.2

Justin Mclean
HI,

Sorry but it’s -1 (binding) due to license and binary issues

I checked:
- Incubating in name
- signatures and hashes are fine
- DISCLAIMER exists
- NOTICE include lists MIT licensed file this should be in LICENSE. This was brought up last release.
- LICENSE is missing above MIT license
- Release include code with incompatibles licenses (see below)
- Looks like there are compiled binaries in the source release [1]
- Can compile from source

I see a number of issues here file have been include that should not be as they contain:
"NOTE: these external pre-packaged configurations are not part of the official
# Apache source release due to CC BY 4.0 licensing.”

That are include in the source release.

Files include:
./nlpcraft/src/main/resources/spell/dictionary.yaml
./nlpcraft/src/main/resources/geo/metro.yaml
./nlpcraft/src/main/resources/geo/continents.yaml
./nlpcraft/src/main/resources/geo/synonyms/states.yaml
./nlpcraft/src/main/resources/geo/synonyms/case_sensitive/list.yaml
./nlpcraft/src/main/resources/geo/synonyms/list.yaml
./nlpcraft/src/main/resources/geo/exceptions/dict.yaml
./nlpcraft/src/main/resources/geo/us_top.yaml
./nlpcraft/src/main/resources/geo/countries/GB.yaml
./nlpcraft/src/main/resources/geo/countries/US.yaml
./nlpcraft/src/main/resources/geo/countries/RU.yaml
./nlpcraft/src/main/resources/geo/world_top.yaml

Thanks,
Justin

1. ./nlpcraft/src/main/resources/opennlp/en-*.bin


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.6.2

Nikita Ivanov
Justin - I think you misread the comments. These comments specifically
address *externally* available pre-packaged configuration that is NOT
included in the release. Here's the full comment in question:

#
# This is the default configuration. Feel free to add to and extend it.
#
# You can also download pre-packaged configuration that is based on the
content
# licensed under Creative Commons Attribution 4.0 International (CC BY 4.0)
# from https://nlpcraft.apache.org/download.html#3rd_party_config
#
# NOTE: these external pre-packaged configurations are not part of the
official
# Apache source release due to CC BY 4.0 licensing.
#
I hope that clarifies that.

Thanks,
--
Nikita Ivanov



On Tue, Jul 21, 2020 at 11:49 PM Justin Mclean <[hidden email]>
wrote:

> HI,
>
> Sorry but it’s -1 (binding) due to license and binary issues
>
> I checked:
> - Incubating in name
> - signatures and hashes are fine
> - DISCLAIMER exists
> - NOTICE include lists MIT licensed file this should be in LICENSE. This
> was brought up last release.
> - LICENSE is missing above MIT license
> - Release include code with incompatibles licenses (see below)
> - Looks like there are compiled binaries in the source release [1]
> - Can compile from source
>
> I see a number of issues here file have been include that should not be as
> they contain:
> "NOTE: these external pre-packaged configurations are not part of the
> official
> # Apache source release due to CC BY 4.0 licensing.”
>
> That are include in the source release.
>
> Files include:
> ./nlpcraft/src/main/resources/spell/dictionary.yaml
> ./nlpcraft/src/main/resources/geo/metro.yaml
> ./nlpcraft/src/main/resources/geo/continents.yaml
> ./nlpcraft/src/main/resources/geo/synonyms/states.yaml
> ./nlpcraft/src/main/resources/geo/synonyms/case_sensitive/list.yaml
> ./nlpcraft/src/main/resources/geo/synonyms/list.yaml
> ./nlpcraft/src/main/resources/geo/exceptions/dict.yaml
> ./nlpcraft/src/main/resources/geo/us_top.yaml
> ./nlpcraft/src/main/resources/geo/countries/GB.yaml
> ./nlpcraft/src/main/resources/geo/countries/US.yaml
> ./nlpcraft/src/main/resources/geo/countries/RU.yaml
> ./nlpcraft/src/main/resources/geo/world_top.yaml
>
> Thanks,
> Justin
>
> 1. ./nlpcraft/src/main/resources/opennlp/en-*.bin
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.6.2

Justin Mclean
Hi,

> Justin - I think you misread the comments. These comments specifically
> address *externally* available pre-packaged configuration that is NOT
> included in the release. Here's the full comment in question:

Those files still contain data, which I’m guessing is a subset of full set? If so that subset would still be under CC BY 4.0 and not allowed in a source release in this form.

Thanks,
Justin


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.6.2

Nikita Ivanov
No, those files were created completely from scratch without any borrowing
from any CC-based sources (thus they are very minimal and serve more of
documentation purpose on how to extend them). All content of the files
shipped in the release is 100% ASL2.0 licensed.

Thanks,
--
Nikita Ivanov



On Wed, Jul 22, 2020 at 3:22 PM Justin Mclean <[hidden email]>
wrote:

> Hi,
>
> > Justin - I think you misread the comments. These comments specifically
> > address *externally* available pre-packaged configuration that is NOT
> > included in the release. Here's the full comment in question:
>
> Those files still contain data, which I’m guessing is a subset of full
> set? If so that subset would still be under CC BY 4.0 and not allowed in a
> source release in this form.
>
> Thanks,
> Justin
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.6.2

Justin Mclean
Hi,

And the binary files?

Thanks,
Justin

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache NLPCraft (Incubating) 0.6.2

Nikita Ivanov
Will be removed in the next release (0.7.0) [1], as well as adding MIT to
LICENSE file [2].

Thank you,

1. https://issues.apache.org/jira/browse/NLPCRAFT-98
2. https://issues.apache.org/jira/browse/NLPCRAFT-97
--
Nikita Ivanov



On Wed, Jul 22, 2020 at 5:12 PM Justin Mclean <[hidden email]>
wrote:

> Hi,
>
> And the binary files?
>
> Thanks,
> Justin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>