[VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Makoto Yui-2
Hi all,

The Apache Hivemall community has approved a proposal to release
Apache Hivemall 0.5.0 (the first Apache release) by v0.5.0-RC2.

We now kindly request that the Incubator PMC members review and vote
on this incubator release candidate.

The PPMC vote thread is located here:
    https://www.mail-archive.com/dev@.../msg00450.html
(vote)
https://www.mail-archive.com/dev@.../msg00460.html
(vote result)

Links to various release artifacts are given below.

    - The source tarball, including signatures, digests, ChangeLog, etc.:
      https://dist.apache.org/repos/dist/dev/incubator/hivemall/0.5.0-incubating-rc2/
    - Sources for the release:
      https://dist.apache.org/repos/dist/dev/incubator/hivemall/0.5.0-incubating-rc2/hivemall-0.5.0-incubating-rc2-source-release.zip
    - Git tag for the release:
      https://git-wip-us.apache.org/repos/asf?p=incubator-hivemall.git;a=shortlog;h=refs/tags/v0.5.0-rc2
    - The Nexus Staging URL:
      https://repository.apache.org/content/repositories/orgapachehivemall-1002/
    - KEYS file for verification:
      https://dist.apache.org/repos/dist/dev/incubator/hivemall/KEYS
    - For information about the contents of this release, see:
      https://dist.apache.org/repos/dist/dev/incubator/hivemall/0.5.0-incubating-rc2/ChangeLog.html

Artifacts verification how-to can be found in
    http://hivemall.incubator.apache.org/verify_artifacts.html

Please vote accordingly:

[ ] +1  approve
[ ] -1  disapprove (and reason why)

The vote will be open for at least 72 hours.

Regards,
Makoto
on behalf of Apache Hivemall PPMC

--
Makoto YUI <myui AT apache.org>
Research Engineer, Treasure Data, Inc.
http://myui.github.io/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Justin Mclean
Hi,

Sorry it -1 from me as there is compiled code in the sure release. [1]

I checked:
- incubating in name
- signatures and hashes fine
- DISCLAIMER exists
- LICENSE is missing several things including the licence appendix and licenses of included software [2]
- NOTICE has some issues
- File have ASF header but there’s some files that header have been added where IMO they should not of been [8][9]
- unexpended binary in source release [1]
- could compile core

Including instructions on how to build from source in the release would be useful.

The source software bundles several bits of software from other projects and these need to be mentioned in LICENSE. Please ask for help from your mentors in fixing this and read this [2]. From what I can see LICENSE is missing:
- MIT and OFL license font awesome [4][5]
- public domain code included in this file [6]
- this BSD licensed file [7] which also incorrectly has an ASF header
- you may or may not want to list other ALv2 pieces of software as well

For the NOTICE the information about relocated copyrights IMO is not correct and should be removed as you want to keep NOTICE files as small as possible. Relocated copyright are usually those relocated to NOTICE as part of a software grant. For instance this file [3] has incorrectly both an ASF header and another Apache license  header and is mentioned as a file who’s header has been relocated in NOTICE. IMO just keep the file’s original header, don’t add an Apache one and there is no need to put anything in NOTICE.

Also please put the actual year not "Copyright 2016 and onwards” in the NOTICE file.

Thanks,
Justin

1. hivemall-0.5.0-incubating-rc2/xgboost/lib/xgboost4j-0.7.jar
2. http://www.apache.org/dev/licensing-howto.html
3. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/classification/DecisionTree.java
4. hivemall-0.5.0-incubating-rc2/src/site/resources/css/font-awesome.css
5. hivemall-0.5.0-incubating-rc2/src/site/resources/fonts/fontawesome-webfont/*
6. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/utils/math/FastMath.java
7. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/utils/codec/Base91.java
8. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/classification/DecisionTree.java
9. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/regression/RegressionTree.java
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Makoto Yui-2
Hi Justin,

Thank you for a careful verification.

[1] is not used anymore and should be removed.

I'll discuss with PPMC members about LICENSE/NOTICE file format.
I'll add appendix to LICENSE file about other license headers.

I used NOTICE file of Hadoop/Spark project as a reference.
https://github.com/apache/hadoop/blob/trunk/NOTICE.txt
https://github.com/apache/spark/blob/master/NOTICE#L2

In your opinion, Hadoop/Spark's NOTICE file is wrong as well.

I'll cancel this release and do release process again but wait for
other IPMC's comment for a while to find other glitches.

Thanks,
Makoto

2018-01-30 8:57 GMT+09:00 Justin Mclean <[hidden email]>:

> Hi,
>
> Sorry it -1 from me as there is compiled code in the sure release. [1]
>
> I checked:
> - incubating in name
> - signatures and hashes fine
> - DISCLAIMER exists
> - LICENSE is missing several things including the licence appendix and licenses of included software [2]
> - NOTICE has some issues
> - File have ASF header but there’s some files that header have been added where IMO they should not of been [8][9]
> - unexpended binary in source release [1]
> - could compile core
>
> Including instructions on how to build from source in the release would be useful.
>
> The source software bundles several bits of software from other projects and these need to be mentioned in LICENSE. Please ask for help from your mentors in fixing this and read this [2]. From what I can see LICENSE is missing:
> - MIT and OFL license font awesome [4][5]
> - public domain code included in this file [6]
> - this BSD licensed file [7] which also incorrectly has an ASF header
> - you may or may not want to list other ALv2 pieces of software as well
>
> For the NOTICE the information about relocated copyrights IMO is not correct and should be removed as you want to keep NOTICE files as small as possible. Relocated copyright are usually those relocated to NOTICE as part of a software grant. For instance this file [3] has incorrectly both an ASF header and another Apache license  header and is mentioned as a file who’s header has been relocated in NOTICE. IMO just keep the file’s original header, don’t add an Apache one and there is no need to put anything in NOTICE.
>
> Also please put the actual year not "Copyright 2016 and onwards” in the NOTICE file.
>
> Thanks,
> Justin
>
> 1. hivemall-0.5.0-incubating-rc2/xgboost/lib/xgboost4j-0.7.jar
> 2. http://www.apache.org/dev/licensing-howto.html
> 3. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/classification/DecisionTree.java
> 4. hivemall-0.5.0-incubating-rc2/src/site/resources/css/font-awesome.css
> 5. hivemall-0.5.0-incubating-rc2/src/site/resources/fonts/fontawesome-webfont/*
> 6. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/utils/math/FastMath.java
> 7. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/utils/codec/Base91.java
> 8. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/classification/DecisionTree.java
> 9. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/regression/RegressionTree.java
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


--
Makoto YUI <myui AT apache.org>
Research Engineer, Treasure Data, Inc.
http://myui.github.io/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Justin Mclean-3
Hi,

> I used NOTICE file of Hadoop/Spark project as a reference.

You should be careful following other TLPs as examples and follow the instructions here. [1] If you want some good example that the HTTP project or TomCat are I believe good ones to follow. That or perhaps more recently graduated projects.

> https://github.com/apache/hadoop/blob/trunk/NOTICE.txt
> https://github.com/apache/spark/blob/master/NOTICE#L2
>
> In your opinion, Hadoop/Spark's NOTICE file is wrong as well.

It may be due to historical reason or they may have included issues due to malformed upstream projects NOTICE files. Which looks to be the case here for Hadoop with the license information being in the NOTICE file, not so sure with Spark. IMO they could do with some improvement but that’s up the PMC of those projects to do that.

> I'll cancel this release and do release process again but wait for
> other IPMC's comment for a while to find other glitches.

That a good idea. You might want to get your mentors to double check the release as well. Did any on them vote on this release candidate? (From a quick look I couldn’t see any mentor votes.)

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Makoto Yui-2
Justin,

2018-01-30 11:33 GMT+09:00 Justin Mclean <[hidden email]>:
> You should be careful following other TLPs as examples and follow the instructions here. [1] If you want some good example that the HTTP project or TomCat are I believe good ones to follow. That or perhaps more recently graduated projects.
>
>> https://github.com/apache/hadoop/blob/trunk/NOTICE.txt
>> https://github.com/apache/spark/blob/master/NOTICE#L2

I'll take a look at Tomcat's one.

>> In your opinion, Hadoop/Spark's NOTICE file is wrong as well.
>
> It may be due to historical reason or they may have included issues due to malformed upstream projects NOTICE files. Which looks to be the case here for Hadoop with the license information being in the NOTICE file, not so sure with Spark. IMO they could do with some improvement but that’s up the PMC of those projects to do that.

IMO, adding license information along with copyrights in NOTICE sounds
reasonable because comparing LICENSE with NOTICE is hard when divided
while it may be redundant.

>> I'll cancel this release and do release process again but wait for
>> other IPMC's comment for a while to find other glitches.
>
> That a good idea. You might want to get your mentors to double check the release as well. Did any on them vote on this release candidate? (From a quick look I couldn’t see any mentor votes.)

Not yet. I'm asking our mentors to join this vote, expecting some of them joins.

BTW, can we remove "rcX" from "x.y.z-rcX" on releasing "x.y.z" without
voting when IPMC vote passed?
Some of other incubator projects do so but I don't have confidence
whether it's okay or not.

Thanks,
Makoto

--
Makoto YUI <myui AT apache.org>
Research Engineer, Treasure Data, Inc.
http://myui.github.io/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

sebb-2-2
On 30 January 2018 at 03:02, Makoto Yui <[hidden email]> wrote:

> Justin,
>
> 2018-01-30 11:33 GMT+09:00 Justin Mclean <[hidden email]>:
>> You should be careful following other TLPs as examples and follow the instructions here. [1] If you want some good example that the HTTP project or TomCat are I believe good ones to follow. That or perhaps more recently graduated projects.
>>
>>> https://github.com/apache/hadoop/blob/trunk/NOTICE.txt
>>> https://github.com/apache/spark/blob/master/NOTICE#L2
>
> I'll take a look at Tomcat's one.
>
>>> In your opinion, Hadoop/Spark's NOTICE file is wrong as well.
>>
>> It may be due to historical reason or they may have included issues due to malformed upstream projects NOTICE files. Which looks to be the case here for Hadoop with the license information being in the NOTICE file, not so sure with Spark. IMO they could do with some improvement but that’s up the PMC of those projects to do that.
>
> IMO, adding license information along with copyrights in NOTICE sounds
> reasonable because comparing LICENSE with NOTICE is hard when divided
> while it may be redundant.

The NOTICE file is like a poem - it is only complete when nothing more
can be taken out.

Nothing must be added to NOTICE unless it is definitely required.

>>> I'll cancel this release and do release process again but wait for
>>> other IPMC's comment for a while to find other glitches.
>>
>> That a good idea. You might want to get your mentors to double check the release as well. Did any on them vote on this release candidate? (From a quick look I couldn’t see any mentor votes.)
>
> Not yet. I'm asking our mentors to join this vote, expecting some of them joins.
>
> BTW, can we remove "rcX" from "x.y.z-rcX" on releasing "x.y.z" without
> voting when IPMC vote passed?
> Some of other incubator projects do so but I don't have confidence
> whether it's okay or not.
>
> Thanks,
> Makoto
>
> --
> Makoto YUI <myui AT apache.org>
> Research Engineer, Treasure Data, Inc.
> http://myui.github.io/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Justin Mclean
In reply to this post by Makoto Yui-2
Hi,

> IMO, adding license information along with copyrights in NOTICE sounds
> reasonable because comparing LICENSE with NOTICE is hard when divided
> while it may be redundant.

In general only LICENSE should contain license information [1] as the NOTICE file is informational only [2], (see d. "The contents of the NOTICE file are for informational purposes only and do not modify the License.") It also should be keep as short as possible [3] as it has an impact on downstream ASF projects.

> BTW, can we remove "rcX" from "x.y.z-rcX" on releasing "x.y.z" without
> voting when IPMC vote passed?

You can name release artefacts however you want as long as it has “incubating” in it. Changing the name of the release (i.e. dropping the RC bit) doesn’t effect the signature or change the file contents so that’s fine. Best to do this via a "svn move” from the dist/dev area to the /dist area.

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#overview-of-files
2. http://www.apache.org/licenses/LICENSE-2.0.html#redistribution (see d. )
3.http://www.apache.org/dev/licensing-howto.html#mod-notice
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Makoto Yui-3
Hi,

>> IMO, adding license information along with copyrights in NOTICE sounds
>> reasonable because comparing LICENSE with NOTICE is hard when divided
>> while it may be redundant.
>
> In general only LICENSE should contain license information [1] as the NOTICE file is informational only [2], (see d. "The contents of the NOTICE file are for informational purposes only and do not modify the License.") It also should be keep as short as possible [3] as it has an impact on downstream ASF projects.

Thank you for pointing out ASF policy. I'll remove licensing
information from NOTICE.

>> BTW, can we remove "rcX" from "x.y.z-rcX" on releasing "x.y.z" without
>> voting when IPMC vote passed?
>
> You can name release artefacts however you want as long as it has “incubating” in it. Changing the name of the release (i.e. dropping the RC bit) doesn’t effect the signature or change the file contents so that’s fine. Best to do this via a "svn move” from the dist/dev area to the /dist area.

On publishing artifacts to Maven, pom versions are written and thus
signature change is actually happening in other release, I think.
Signature of XXX.src.zip can be unchanged though.

Thanks,
Makoto

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Makoto Yui-2
In reply to this post by Justin Mclean
Hi Justin,

I'm revising LICENSE and NOTICE files following your comments and [D].

https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L205
(copyrights are removed from LICENSE)
https://github.com/apache/incubator-hivemall/blob/v0.5.0/NOTICE

Does it seem okey for you?

[D] says 'Copyright notifications which have been relocated from
source files (rather than removed) must be preserved in NOTICE.'.

> For instance this file [3] has incorrectly both an ASF header and another Apache license header and is mentioned as a file who’s header has been relocated in NOTICE. IMO just keep the file’s original header, don’t add an Apache one and there is no need to put anything in NOTICE.

I'm wondering how to fix the license headers of modified codes.

Just writing the original header is not enough because it has
additional/modified codes (e.g., when only a method is reused from
original file).
I think then both original copyright and copyright by our ASF project
should be listed.

Specifically,

> File have ASF header but there’s some files that header have been added where IMO they should not of been [8][9]

[8][9] is an aggressively modified version of original code and thus
having both the original header and ASF header is expected.
Both our copyright and the original copyright should be kept.
Duplicate entries of ASF license can be eliminated though.

I'm consider to use LicenseHeader1.java format of [B]
(LicenseHeader2.java format of [B] is invalid in RAT check).

> this BSD licensed file [7] which also incorrectly has an ASF header

It's a modified version (encoding/decoding table is changed) of [A]
and thus having both the original header and ASF header is expected.

Having both header for modified code seems to be existing in various
TLP projects (e.g., [C]), passing legal checks.

Thanks,
Makoto

[7] hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/utils/codec/Base91.java
[8] hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/classification/DecisionTree.java
[9] hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/regression/RegressionTree.java
[A] https://github.com/bwaldvogel/base91/blob/670c254f90c9f588e4590bbf6765ac07e996492b/src/main/java/de/bwaldvogel/base91/Base91.java
[B] https://gist.github.com/myui/20f1d18253b5cfc018c06429eb07bc57
[C] https://github.com/apache/hadoop/blob/f67237cbe7bc48a1b9088e990800b37529f1db2a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/bloom/HashFunction.java
[D] http://www.apache.org/dev/licensing-howto.html#mod-notice

2018-01-30 8:57 GMT+09:00 Justin Mclean <[hidden email]>:

> Hi,
>
> Sorry it -1 from me as there is compiled code in the sure release. [1]
>
> I checked:
> - incubating in name
> - signatures and hashes fine
> - DISCLAIMER exists
> - LICENSE is missing several things including the licence appendix and licenses of included software [2]
> - NOTICE has some issues
> - File have ASF header but there’s some files that header have been added where IMO they should not of been [8][9]
> - unexpended binary in source release [1]
> - could compile core
>
> Including instructions on how to build from source in the release would be useful.
>
> The source software bundles several bits of software from other projects and these need to be mentioned in LICENSE. Please ask for help from your mentors in fixing this and read this [2]. From what I can see LICENSE is missing:
> - MIT and OFL license font awesome [4][5]
> - public domain code included in this file [6]
> - this BSD licensed file [7] which also incorrectly has an ASF header
> - you may or may not want to list other ALv2 pieces of software as well
>
> For the NOTICE the information about relocated copyrights IMO is not correct and should be removed as you want to keep NOTICE files as small as possible. Relocated copyright are usually those relocated to NOTICE as part of a software grant. For instance this file [3] has incorrectly both an ASF header and another Apache license  header and is mentioned as a file who’s header has been relocated in NOTICE. IMO just keep the file’s original header, don’t add an Apache one and there is no need to put anything in NOTICE.
>
> Also please put the actual year not "Copyright 2016 and onwards” in the NOTICE file.
>
> Thanks,
> Justin
>
> 1. hivemall-0.5.0-incubating-rc2/xgboost/lib/xgboost4j-0.7.jar
> 2. http://www.apache.org/dev/licensing-howto.html
> 3. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/classification/DecisionTree.java
> 4. hivemall-0.5.0-incubating-rc2/src/site/resources/css/font-awesome.css
> 5. hivemall-0.5.0-incubating-rc2/src/site/resources/fonts/fontawesome-webfont/*
> 6. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/utils/math/FastMath.java
> 7. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/utils/codec/Base91.java
> 8. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/classification/DecisionTree.java
> 9. hivemall-0.5.0-incubating-rc2/core/src/main/java/hivemall/smile/regression/RegressionTree.java
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>



--
Makoto YUI <myui AT apache.org>
Research Engineer, Treasure Data, Inc.
http://myui.github.io/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Makoto Yui-2
2018-02-06 15:49 GMT+09:00 Makoto Yui <[hidden email]>:
> https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L205
> (copyrights are removed from LICENSE)
> https://github.com/apache/incubator-hivemall/blob/v0.5.0/NOTICE

Let me correct. LICENSE information is removed from NOTICE.

Makoto

--
Makoto YUI <myui AT apache.org>
Research Engineer, Treasure Data, Inc.
http://myui.github.io/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Justin Mclean
In reply to this post by Makoto Yui-2
Hi,

Note the mix of public and private lists (as I’m replying to where it was sent).

 However I think this should be discussed on dev@hivemall not private@.

> I'm revising LICENSE and NOTICE files following your comments and [D].
>
> https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L205
> (copyrights are removed from LICENSE)
> https://github.com/apache/incubator-hivemall/blob/v0.5.0/NOTICE
>
> Does it seem okey for you?

From a quick look:
- In LICENSE you need to link to the full text of the license locally not via URL [1] licenses at URLs can change over time. Having the exact version and a URL is useful but shouldn’t be the primary way to include license information.
- The NOTICE file still contains too much information [2]

Your mentors can help you out with this, please ask them to help.

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
2. http://www.apache.org/dev/licensing-howto.html#mod-notice
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Justin Mclean
In reply to this post by Makoto Yui-2
Hi,

> I'm wondering how to fix the license headers of modified codes.

See points 3 to 5 of [1] so unless major changes have been made it best to keep the original header and not add an ASF one. Points 1 and 2 are sort of important as well :-)

Thanks,
Justin

1. https://www.apache.org/legal/src-headers.html#3party


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Makoto Yui-2
In reply to this post by Justin Mclean
Hi Justin,

Thank you for your reply.

2018-02-06 16:12 GMT+09:00 Justin Mclean <[hidden email]>:
> Note the mix of public and private lists (as I’m replying to where it was sent).

CC'd private@ to notify discussion to our project mentors. Changed to dev@

> From a quick look:
> - In LICENSE you need to link to the full text of the license locally not via URL [1] licenses at URLs can change over time. Having the exact version and a URL is useful but shouldn’t be the primary way to include license information.

To clear discussion, the missing license body is specifically for
https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L315

font-awesome does not include license body just use link to OFL 1.1
for Font license.
https://github.com/FortAwesome/Font-Awesome/blob/master/LICENSE.txt#L13

We need to fill copyrights of OFL 1.1 [2] but copyright of
font-awesome is unclear.
OFL 1.1 copyright form is not willed.
https://github.com/FortAwesome/Font-Awesome/issues/5281

Font-awesome uses github mention for Copyright (unclear).
https://github.com/apache/incubator-hivemall/blob/master/src/site/resources/css/font-awesome.css#L2

BTW, font-awesome is widely used in many ASF projects.
https://github.com/search?utf8=%E2%9C%93&q=org%3Aapache+SIL+Open+Font+License+filename%3ALICENSE&type=Code

So, I would like to follow the other TLP project passing ASF legal
checks for this incubator release.
https://github.com/apache/flink/blob/34e106f63c9dcd2673d66b47fda1555b7dced770/LICENSE#L301
https://github.com/apache/tez/blob/247719d7314232f680f028f4e1a19370ffb7b1bb/tez-dist/dist-files/full/LICENSE#L352
https://github.com/apache/calcite/blob/0938c7b6d767e3242874d87a30d9112512d9243a/LICENSE#L264
https://github.com/apache/phoenix/blob/ee4355791acf3f31568fcd8c43367947d25a1386/LICENSE#L233

Isn't it acceptable?

> - The NOTICE file still contains too much information [2]

Made NOTICE clean and revised License headers following [1] with the
following commit:

https://github.com/apache/incubator-hivemall/commit/147f26fa25bacb4134256a01f6ff84e14a505b7a

I expect it resolves your concern.

> Your mentors can help you out with this, please ask them to help.

Sure.

Makoto

[1] https://www.apache.org/legal/src-headers.html#3party
[2] http://scripts.sil.org/cms/scripts/render_download.php?format=file&media_id=OFL_plaintext&filename=OFL.txt

--
Makoto YUI <myui AT apache.org>
Research Engineer, Treasure Data, Inc.
http://myui.github.io/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Justin Mclean
Hi,

> To clear discussion, the missing license body is specifically for
> https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L315

Again please carefully read [1] to comply you need to include a pointer to the full text of the license not a URL. If you need to download the license text and place that in a file in the release please do so.

> Font-awesome uses github mention for Copyright (unclear).
> https://github.com/apache/incubator-hivemall/blob/master/src/site/resources/css/font-awesome.css#L2

Also note you include code which is CC-BY according to [3].

> BTW, font-awesome is widely used in many ASF projects.
> https://github.com/search?utf8=%E2%9C%93&q=org%3Aapache+SIL+Open+Font+License+filename%3ALICENSE&type=Code

It's normally used as part of bootstrap and the license in that case is clearer.

> So, I would like to follow the other TLP project passing ASF legal checks for this incubator release.

TLP may have historical reasons for the contents of LICENSE and NOTICE and policy has changed over time.  While good for guidance please don’t assume that just because a TLP does something some way that it’s OK for your project to do it the same way.

> https://github.com/apache/flink/blob/34e106f63c9dcd2673d66b47fda1555b7dced770/LICENSE#L301
> https://github.com/apache/tez/blob/247719d7314232f680f028f4e1a19370ffb7b1bb/tez-dist/dist-files/full/LICENSE#L352
> https://github.com/apache/calcite/blob/0938c7b6d767e3242874d87a30d9112512d9243a/LICENSE#L264
> https://github.com/apache/phoenix/blob/ee4355791acf3f31568fcd8c43367947d25a1386/LICENSE#L233
>
> Isn't it acceptable?

IMO from a quick look none of those are acceptable but that’s for their PMCs to deal with not the incubator. It may be that they included the full text of the license elsewhere.

>
>> - The NOTICE file still contains too much information [2]
>
> Made NOTICE clean and revised License headers following [1] with the
> following commit:

I see you are still listing the copyrights in NOTICE. Again please ask your mentors for help on what is required here.

> I expect it resolves your concern.

No I would still vote -1 on a release with those changes.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Justin Mclean
Hi,

Sorry links got removed for some reason. Again please read [1] and check the CC-BY license [2][, you may also want to read [3] re CC-BY which may be an issue here. However it's not clear what version of font awesome you are including the links provided refer to version 5 which is under slightly different licensing terms to pervious versions.

Thanks,
Justin

1.http://www.apache.org/dev/licensing-howto.html#permissive-deps
2. https://github.com/FortAwesome/Font-Awesome/blob/master/LICENSE.txt
3. https://www.apache.org/legal/resolved.html#category-b


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Justin Mclean
Hi,

Yep looks like you are including Font Awesome 4.6.3 not 5.  [1] A good reason to put the exact version of the 3rd party software somewhere so you know which license applies.

Thanks,
Justin

1. https://github.com/apache/incubator-hivemall/blob/a31d0aab3f419812cae7da426f6dcdc9a7be72b5/src/site/resources/css/font-awesome.css
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Makoto Yui-3
In reply to this post by Justin Mclean
Hi Justin,

2018-02-06 17:53 GMT+09:00 Justin Mclean <[hidden email]>:
> Hi,
>
>> To clear discussion, the missing license body is specifically for
>> https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L315
>
> Again please carefully read [1] to comply you need to include a pointer to the full text of the license not a URL. If you need to download the license text and place that in a file in the release please do so.

I put License file of OFL 1.1 in the distribution and put link to it
in the LICENSE.
https://github.com/apache/incubator-hivemall/commit/446eac6703270aa00c8cb00dd115e7500faf6518

Font-awesome v4.6.3 uses SIL OFL 1.1 for it's License.
https://github.com/FortAwesome/Font-Awesome/blob/v4.6.3/css/font-awesome.css#L3

I assume we do not need to put Apache LICENSE v2 file for
https://github.com/apache/incubator-hivemall/blob/v0.5.0/LICENSE#L216

For other licenses, full texts of licenses are included.

>>> - The NOTICE file still contains too much information [2]
>>
>> Made NOTICE clean and revised License headers following [1] with the
>> following commit:
>
> I see you are still listing the copyrights in NOTICE. Again please ask your mentors for help on what is required here.

Update the NOTICE file.
https://github.com/apache/incubator-hivemall/blob/v0.5.0/NOTICE

[1] http://apache.org/legal/src-headers.html#notice
says "The NOTICE file may also include copyright notices moved from
source files submitted to the ASF."

Tomcat states "Copyright 2014 The Netty Project" and "Copyright 2014
Twitter" following [1].
https://github.com/apache/tomcat/blob/trunk/NOTICE#L28

For our case, copyright before entering incubators are L10-13.
The three copyright holders sent SGA when entering Incubator.

You concern cleared?

Thanks,
Makoto

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Justin Mclean-3
Hi,

> Update the NOTICE file.
> https://github.com/apache/incubator-hivemall/blob/v0.5.0/NOTICE

Look there is obvious a disconnect here and you are not understanding what isand  required in regard with licensing and ASF policy. That's OK as incubating project, it's hard to understand and hard to get right especially when this is new to you, and guidance is not always clear and TLP project seem to not comply. Again I ask you to ask your mentors to help.

> Tomcat states "Copyright 2014 The Netty Project" and "Copyright 2014
> Twitter" following [1].
> https://github.com/apache/tomcat/blob/trunk/NOTICE#L28

Which has been discussed on this list before as is not related to copyright it to do with propagation of the contents of bundled Apache licensed NOTICE file. Netty has it’s own issues re it’s NOTICE file.

> You concern cleared?

No I would still vote -1. Again please speak to your mentors and understand what the issues are here before bring the vote back to a incubator vote.

That’s the last I have to say on this before we see a new RC.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Hivemall (Incubating) v0.5.0-RC2

Makoto Yui-3
Justin,

2018-02-06 22:07 GMT+09:00 Justin Mclean <[hidden email]>:
> Hi,
>
>> Update the NOTICE file.
>> https://github.com/apache/incubator-hivemall/blob/v0.5.0/NOTICE
>
> Look there is obvious a disconnect here and you are not understanding what isand  required in regard with licensing and ASF policy. That's OK as incubating project, it's hard to understand and hard to get right especially when this is new to you, and guidance is not always clear and TLP project seem to not comply. Again I ask you to ask your mentors to help.

I'm currently asking our mentor though not all our mentors would not
be experts of licensing issue.

Again, http://apache.org/legal/src-headers.html#notice says
"The NOTICE file *may* also include copyright notices moved from
source files submitted to the ASF."

SGA providers would expect copyright are left in somewhere.
https://github.com/myui/hivemall/blob/v0.4.2-rc.2/NOTICE#L8 (before
entering Incubator)

I'll ask about this issue to confirm about the above guidance in legal-discuss@.

> No I would still vote -1. Again please speak to your mentors and understand what the issues are here before bring the vote back to a incubator vote.
>
> That’s the last I have to say on this before we see a new RC.

Thank you for taking your time.

Makoto

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]